chore: Change ints to 'number' for ProgressEvent properties #39574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @domenic |
|
Preview URLs
(comment last updated: 2025-05-30 10:26:33) |
Josh-Cena
reviewed
May 21, 2025
bsmth
commented
May 21, 2025
bsmth
commented
May 21, 2025
Josh-Cena
approved these changes
May 23, 2025
bsmth
commented
May 30, 2025
bsmth
commented
May 30, 2025
bsmth
commented
May 30, 2025
bsmth
commented
May 30, 2025
bsmth
commented
May 30, 2025
bsmth
commented
May 30, 2025
Yeah that's a good point, motivation is:
https://webmachinelearning.github.io/writing-assistance-apis/#note-download-progress-fraction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The docs are explicit about ints here, and changes have landed allowing doubles:
https://xhr.spec.whatwg.org/#dom-progresseventinit-loaded
Related issues and pull requests
Fixes mdn/mdn#641